MNTOR-4267: Set e2e feature flags reliably #5917
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The manual calls to `beforeEach` were not guaranteerd to run before other `beforeEach` calls - some of which did the initial page navigation. This meant that some tests would sometimes be interacting with pages that would have been loaded without setting the x-forced-feature-flags header, and thus not have the feature flags applied. This method was sourced from microsoft/playwright#9468 (comment)
|
Preview URL 🚀 : https://blurts-server-pr-5917-mgjlpikfea-uk.a.run.app |
|
Another attempt at #5923. |
|
Cleanup completed - database 'blurts-server-pr-5917' destroyed, cloud run service 'blurts-server-pr-5917' destroyed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Second attempt; see if CI has no cache errors now.)
The manual calls to
beforeEachwere not guaranteerd to run before otherbeforeEachcalls - some of which did the initial page navigation. This meant that some tests would sometimes be interacting with pages that would have been loaded without setting the x-forced-feature-flags header, and thus not have the feature flags applied.This method was sourced from
microsoft/playwright#9468 (comment)
The tl;dr is that the
scope: "test", auto: truemakes sure the fixturesharedBeforeEachis loaded automatically before each test, without the test needing to manually specify them like they do e.g. forAuthPage,LandingPage, etc.