Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNTOR-3917: Add plaintext version of Plus expiration email #5562

Merged
merged 2 commits into from
Feb 5, 2025

Conversation

Vinnl
Copy link
Collaborator

@Vinnl Vinnl commented Jan 29, 2025

References:

Jira: MNTOR-3917
Figma:

Description

I figured I'd move the plaintext version into a separate PR, since it's not crucial functionality.

How to test

You can view the version in Storybook, and the admin UI will also send both the HTML and plaintext version. Mailinator will let you inspect both.

Checklist (Definition of Done)

  • Localization strings (if needed) have been added.
  • Commits in this PR are minimal and have descriptive commit messages.
  • I've added or updated the relevant sections in readme and/or code comments
  • I've added a unit test to test for potential regressions of this bug. - Hmm, I suppose it wouldn't hurt - but I'm going to focus on getting the rest over the line first
  • If this PR implements a feature flag or experimentation, I've checked that it still works with the flag both on, and with the flag off.
  • If this PR implements a feature flag or experimentation, the Ship Behind Feature Flag status in Jira has been set
  • Product Owner accepted the User Story (demo of functionality completed) or waived the privilege.
  • All acceptance criteria are met.
  • Jira ticket has been updated (if needed) to match changes made during the development process.
  • Jira ticket has been updated (if needed) with suggestions for QA when this PR is deployed to stage.

@Vinnl Vinnl added the Review: XS Code review time: up to 30min label Jan 29, 2025
@Vinnl Vinnl requested review from codemist and flozia January 29, 2025 15:17
@Vinnl Vinnl self-assigned this Jan 29, 2025
@Vinnl Vinnl requested a review from flodolo as a code owner January 29, 2025 15:17
Copy link

@Vinnl Vinnl force-pushed the MNTOR-3917-followups branch from 8631e09 to 3c43739 Compare January 29, 2025 15:57
Base automatically changed from MNTOR-3917-followups to main January 29, 2025 16:05
@Vinnl Vinnl force-pushed the MNTOR-3917-plaintext branch 2 times, most recently from 111ab5d to e6a6ce3 Compare February 5, 2025 11:34
@Vinnl Vinnl force-pushed the MNTOR-3917-plaintext branch from 4066cf4 to 0746355 Compare February 5, 2025 12:16
@Vinnl Vinnl merged commit 5533a3c into main Feb 5, 2025
16 checks passed
@Vinnl Vinnl deleted the MNTOR-3917-plaintext branch February 5, 2025 12:28
Copy link

github-actions bot commented Feb 5, 2025

Cleanup completed - database 'blurts-server-pr-5562' destroyed, cloud run service 'blurts-server-pr-5562' destroyed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review: XS Code review time: up to 30min
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants