-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add app_store_choice_screen_selection ETL to pull the new version of DMA related report #6790
Merged
kik-kik
merged 1 commit into
main
from
feat/DENG-7213/pull-apple-choice-screen-reports-for-ios-18.3-and-above
Jan 14, 2025
Merged
feat: add app_store_choice_screen_selection ETL to pull the new version of DMA related report #6790
kik-kik
merged 1 commit into
main
from
feat/DENG-7213/pull-apple-choice-screen-reports-for-ios-18.3-and-above
Jan 14, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on of DMA related report
Integration report for "feat: add app_store_choice_screen_selection ETL to pull the new version of DMA related report"
|
kwindau
approved these changes
Jan 10, 2025
Good work here although I hope there aren't any more changes from Apple API in future but can't guarantee. Your implementation is sound 👌 |
kik-kik
deleted the
feat/DENG-7213/pull-apple-choice-screen-reports-for-ios-18.3-and-above
branch
January 14, 2025 13:34
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: add app_store_choice_screen_selection ETL to pull the new version of DMA related report
Description
Apple made some changes which resulted in Choice Screen related report evolving and completely changing its shape. This report include all clients on iOS 18.2 and above and those will not be available in the previous version
app_store_choice_screen_engagement
ETL.Once this change is merged we should backfill the data starting
2024-12-05
.┆Issue is synchronized with this Jira Task