feat: make sure that device_manufacturer is lowered prior to joining

mozilla · Jan 14, 2025 · 14b2235 · 14b2235
1 parent cccde89
commit 14b2235
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/sql_generators/mobile_kpi_support_metrics/templates/engagement.query.sql b/sql_generators/mobile_kpi_support_metrics/templates/engagement.query.sql
@@ -3,7 +3,7 @@ WITH device_manufacturer_counts AS (
   SELECT
     submission_date,
     device_manufacturer,
-    DENSE_RANK() OVER(PARTITION BY submission_date ORDER BY COUNT(*) DESC) AS manufacturer_rank,
+    RANK() OVER(PARTITION BY submission_date ORDER BY COUNT(*) DESC) AS manufacturer_rank,
   FROM
   `{{ project_id }}.{{ dataset }}.engagement_clients`
   WHERE

diff --git a/sql_generators/mobile_kpi_support_metrics/templates/new_profiles.query.sql b/sql_generators/mobile_kpi_support_metrics/templates/new_profiles.query.sql
@@ -3,7 +3,7 @@ WITH device_manufacturer_counts AS (
   SELECT
     first_seen_date,
     device_manufacturer,
-    DENSE_RANK() OVER(PARTITION BY submission_date ORDER BY COUNT(*) DESC) AS manufacturer_rank,
+    RANK() OVER(PARTITION BY first_seen_date ORDER BY COUNT(*) DESC) AS manufacturer_rank,
   FROM
   `{{ project_id }}.{{ dataset }}.new_profile_clients`
   WHERE

diff --git a/sql_generators/mobile_kpi_support_metrics/templates/retention.query.sql b/sql_generators/mobile_kpi_support_metrics/templates/retention.query.sql
@@ -3,7 +3,7 @@ WITH device_manufacturer_counts AS (
   SELECT
     submission_date,
     device_manufacturer,
-    DENSE_RANK() OVER(PARTITION BY submission_date ORDER BY COUNT(*) DESC) AS manufacturer_rank,
+    RANK() OVER(PARTITION BY submission_date ORDER BY COUNT(*) DESC) AS manufacturer_rank,
   FROM
   `{{ project_id }}.{{ dataset }}.retention_clients`
   WHERE