Skip to content

Add build tooling so we can work in mozilla-central. #6692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mhammond
Copy link
Member

@mhammond mhammond commented Apr 8, 2025

Most of the files here are ignored when in application-services, but when copied into mozilla-central they enable "mach build" to build our megazord and other tooling.

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

Branch builds: add [firefox-android: branch-name] to the PR title.

@mhammond mhammond force-pushed the push-qmtokoyyolvz branch from 5ca8300 to 01bdc5d Compare April 11, 2025 13:46
@mhammond mhammond force-pushed the push-qmtokoyyolvz branch from 01bdc5d to 719e6e5 Compare April 11, 2025 18:53
@mhammond mhammond force-pushed the push-qmtokoyyolvz branch from 719e6e5 to 09d3194 Compare April 21, 2025 01:55
@mhammond mhammond force-pushed the push-qmtokoyyolvz branch 2 times, most recently from 5e07d58 to b967512 Compare April 29, 2025 18:46
@mhammond
Copy link
Member Author

@glandium I'd love your eyes on this if you have a sec. I'll get a more formal review from the build peers as this gets ready to actually land in m-c, but the earlier I get feedback the better.

@mhammond mhammond force-pushed the push-qmtokoyyolvz branch 2 times, most recently from 224496e to ab48393 Compare April 30, 2025 16:48
@glandium
Copy link
Contributor

glandium commented May 1, 2025

Nothing particularly seems to be wrong in this patch. You'll probably have to discover the horror show that is using nss in rust tests, where you'll probably have to look at what e.g. neqo crates do.

@mhammond mhammond requested a review from bendk May 1, 2025 13:43
@mhammond mhammond marked this pull request as ready for review May 1, 2025 13:43
@mhammond mhammond force-pushed the push-qmtokoyyolvz branch from ab48393 to 232ac74 Compare May 1, 2025 14:47
Most of the files here are ignored when in application-services, but
when copied into mozilla-central they enable "mach build" to build our
megazord and other tooling.
@mhammond mhammond force-pushed the push-qmtokoyyolvz branch from 232ac74 to acfd9b7 Compare May 22, 2025 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants