Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1950993 - Generate Kotlin bindings for search component #6620

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sarah541
Copy link

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

Branch builds: add [firefox-android: branch-name] to the PR title.

bendk
bendk previously requested changes Feb 27, 2025
Copy link
Contributor

@bendk bendk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try running cargo fmt --fix to fix that module import order issue.

Other than that this looks pretty good to me -- assuming the rest of the CI is green.

@mergify mergify bot dismissed bendk’s stale review February 28, 2025 20:38

The pull request has been modified, dismissing previous reviews.

@sarah541
Copy link
Author

Try running cargo fmt --fix to fix that module import order issue.

Other than that this looks pretty good to me -- assuming the rest of the CI is green.

Thank you! cargo fmt seemed to automatically fix rust formatting

@sarah541 sarah541 requested a review from bendk February 28, 2025 21:12
bendk
bendk previously approved these changes Feb 28, 2025
Copy link
Contributor

@bendk bendk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great approving now. There's git conflicts, but they seem pretty straightforward, it's kind of amazing to see so much activity at once.

@mergify mergify bot dismissed bendk’s stale review February 28, 2025 21:30

The pull request has been modified, dismissing previous reviews.

@sarah541 sarah541 requested a review from bendk February 28, 2025 22:37
bendk
bendk previously approved these changes Mar 3, 2025
@bendk
Copy link
Contributor

bendk commented Mar 3, 2025

Still looks great, I'm not sure why mergify makes me approve twice.

@bendk bendk added this pull request to the merge queue Mar 3, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 3, 2025
@mergify mergify bot dismissed bendk’s stale review March 3, 2025 17:30

The pull request has been modified, dismissing previous reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants