-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1950993 - Generate Kotlin bindings for search component #6620
base: main
Are you sure you want to change the base?
Conversation
1409bc0
to
8de359f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Try running cargo fmt --fix
to fix that module import order issue.
Other than that this looks pretty good to me -- assuming the rest of the CI is green.
8de359f
to
01be3fe
Compare
The pull request has been modified, dismissing previous reviews.
Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great approving now. There's git conflicts, but they seem pretty straightforward, it's kind of amazing to see so much activity at once.
01be3fe
to
c92ca65
Compare
The pull request has been modified, dismissing previous reviews.
Still looks great, I'm not sure why mergify makes me approve twice. |
c92ca65
to
00dd19f
Compare
The pull request has been modified, dismissing previous reviews.
Pull Request checklist
[ci full]
to the PR title.Branch builds: add
[firefox-android: branch-name]
to the PR title.