Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: NSSKeyManager for logins component #6571

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jo
Copy link
Contributor

@jo jo commented Jan 27, 2025

Add a NSSKeyManager for the Logins component. This enables the use of NSS for key management, like currently done in desktop.

Note: Currently there are no tests for the NSSKeyManager. This is due to the implicit nss initialization, resulting in nss being initialized without a profile by other tests.

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

Branch builds: add [firefox-android: branch-name] to the PR title.

@jo jo force-pushed the nss-key-manager branch 3 times, most recently from e28cb40 to 518b2af Compare January 27, 2025 22:43
@jo jo force-pushed the nss-key-manager branch 5 times, most recently from d40e969 to 350e238 Compare February 11, 2025 11:01
@jo jo force-pushed the nss-key-manager branch 2 times, most recently from a0b6eda to e3ac09e Compare February 13, 2025 12:30
Add a NSSKeyManager for the Logins component. This enables the use of
NSS for key management, like currently done on desktop.
@jo jo force-pushed the nss-key-manager branch from e3ac09e to 7903b1e Compare February 14, 2025 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant