Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: developer appeals can be attached to actions that won't have a good result #15285

Open
1 task done
ioanarusiczki opened this issue Jan 16, 2025 · 1 comment
Open
1 task done

Comments

@ioanarusiczki
Copy link

ioanarusiczki commented Jan 16, 2025

What happened?

While making checks on #15182 I've noticed the following:

Case A:

  • listed/unlisted versions are reviewed. Decision is to block + disable automatically these versions
  • developer is getting an email and sends an appeal
  • on the review pages the appeal can also be attached to force enable action

Result: an email is sent that the version(s) are now available but the're not (there are other actions to take before making them available again)

Tested with:
unlisted https://reviewers.addons-dev.allizom.org/en-US/reviewers/review-unlisted/635449
listed https://reviewers.addons-dev.allizom.org/en-US/reviewers/review-listed/635458

Image

Case B:

  • listed/unlisted versions rejected
  • developer is sending an appeal
  • versions get flagged for HR
  • appeal can be attached to force disable action

Result: a new email with an appeal url is sent to developer

Image

What did you expect to happen?

Maybe it should not be possible to attach the appeal to these actions.

After blocking there's other steps to take for resolving the appeal to reinstate content or deny the appeal.

Is there an existing issue for this?

  • I have searched the existing issues

┆Issue is synchronized with this Jira Task

@ioanarusiczki
Copy link
Author

Case C:

https://reviewers.addons-dev.allizom.org/en-US/reviewers/review-listed/635368

  • a version was reported for abuse report and delay rejected
  • delay expires the final email is sent to the developer with an appeal url
  • developer sends the appeal
  • the version is flagged for HR
  • check the appeal from dsa section + confirm approval

Result: an email is sent about content being reinstated which is not correct

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants