Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task]: Refactor CinderJob and ContentDecision to allow consistent use between Cinder and reviewer tools #15220

Closed
1 of 2 tasks
eviljeff opened this issue Dec 4, 2024 · 2 comments · Fixed by mozilla/addons-server#22967
Assignees
Labels
qa:verified_fix repository:addons-server Issue relating to addons-server
Milestone

Comments

@eviljeff
Copy link
Member

eviljeff commented Dec 4, 2024

Description

Currently there are two independent code paths for a decision that's made to take down an add-on if it's taken via the reviewer tools, or taken via Cinder. Mainly because the reviewer tools carries out the action first; then logs the decision with Cinder; whereas a Cinder originated decision (obviously) has already logged the the decision; then we carry out the action.
It also allowed one workflow to be developed without considering - or regressing - the other workflow. But the duplication is a net negative in mature code, and means that implementing new features means double the engineering effort. We should bit the bullet and refactor the differences away

Acceptance Criteria

Milestones/checkpoints

Preview Give feedback

Checks

  • If I have identified that the work is specific to a repository, I have removed "repository:addons-server" or "repository:addons-frontend"

┆Issue is synchronized with this Jira Task

@ioanarusiczki
Copy link

I verified on AMO dev

Emails should be as expected ✅, an example

Image

I tried:

reject a listed version ✅
https://reviewers.addons-dev.allizom.org/en-US/reviewers/review-listed/635302

multiple reject for unlisted ✅
https://reviewers.addons-dev.allizom.org/en-US/reviewers/review-unlisted/635373

abuse report -> rejected from rev tools ✅
https://reviewers.addons-dev.allizom.org/en-US/reviewers/review-listed/635366

abuse report with cinder ✅
https://reviewers.addons-dev.allizom.org/en-US/reviewers/review/635304

delay reject (set up for 2 days) ❎ -- in progress, waiting for delay to expire
https://reviewers.addons-dev.allizom.org/en-US/reviewers/review-listed/635367

delay reject with an abuse report ❎ - in progress, waiting for delay to expire
https://reviewers.addons-dev.allizom.org/en-US/reviewers/review-listed/635368

@ioanarusiczki
Copy link

delay reject (set up for 2 days) ❎ -- in progress, waiting for delay (of 2 days) to expire
https://reviewers.addons-dev.allizom.org/en-US/reviewers/review-listed/635367

  • first email sent ✅
  • second email sent with 1 day prior to rejection ✅
  • final email at rejection with an appeal url attached ✅
  • appeal is sent by developer ✅
  • version is flagged for HR in the Manual Review Queue ✅
  • resolved with unreject + approve: content is reinstated ✅
  • email is sent to the developer - that previous decision was incorrect ✅

delay reject with an abuse report ❎ - in progress, waiting for delay to expire
https://reviewers.addons-dev.allizom.org/en-US/reviewers/review-listed/635368

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified_fix repository:addons-server Issue relating to addons-server
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants