Merge pull request #1595 from lissyx/fix-nodejs-python-prod

Enforce same sox options as libsox for C++ client
mozilla · Sep 26, 2018 · 1546576 · 1546576
2 parents e17105f + 1362b50
commit 1546576
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 2 deletions.
diff --git a/native_client/javascript/client.js b/native_client/javascript/client.js
@@ -73,7 +73,20 @@ function bufferToStream(buffer) {
 
 var audioStream = new MemoryStream();
 bufferToStream(buffer).
-  pipe(Sox({ output: { bits: 16, rate: 16000, channels: 1, type: 'raw' } })).
+  pipe(Sox({
+    global: {
+      'no-dither': true,
+    },
+    output: {
+      bits: 16,
+      rate: 16000,
+      channels: 1,
+      encoding: 'signed-integer',
+      endian: 'little',
+      compression: 0.0,
+      type: 'raw'
+    }
+  })).
   pipe(audioStream);
 
 audioStream.on('finish', () => {

diff --git a/native_client/python/client.py b/native_client/python/client.py
@@ -41,7 +41,7 @@
 N_CONTEXT = 9
 
 def convert_samplerate(audio_path):
-    sox_cmd = 'sox {} --type raw --bits 16 --channels 1 --rate 16000 - '.format(quote(audio_path))
+    sox_cmd = 'sox {} --type raw --bits 16 --channels 1 --rate 16000 --encoding signed-integer --endian little --compression 0.0 --no-dither - '.format(quote(audio_path))
     try:
         output = subprocess.check_output(shlex.split(sox_cmd), stderr=subprocess.PIPE)
     except subprocess.CalledProcessError as e: