bug-1945556: omit example data when elasticsearch would error #6890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and enable full version of all text fields so they can have example data
relud
commented
Feb 3, 2025
| # text fields only get example data if they have a full version or | ||
| # include fielddata, like for semicolon_keywords fields. | ||
| super_search_field["has_full_version"] | ||
| or super_search_field["storage_mapping"]["type"] != "text" |
There was a problem hiding this comment.
this will also work for es 1.4 because there the type is "string" and does support aggregations
relud
commented
Feb 3, 2025
| "type": "text", | ||
| }, | ||
| }, | ||
| "minidump_sha256_hash": text_field("minidump_sha256_hash"), |
There was a problem hiding this comment.
should this be a keyword field?
willkg
approved these changes
Feb 4, 2025
| @@ -78,16 +78,15 @@ <h1>{{ field_name }}</h1> | |||
| {% for item in example_data %} | |||
| <div class="field-example"><code>{{ item|string|truncate(100, killwords=True, end="...") }}</code></div> | |||
| {% endfor %} | |||
| {% elif "protected" in permissions %} | |||
There was a problem hiding this comment.
Weird. I wonder why I didn't do an elif before.
webapp/crashstats/documentation/jinja2/docs/datadictionary/field_doc.html
Outdated
Show resolved
Hide resolved
Co-authored-by: Will Kahn-Greene <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and enable full version of all text fields so they still have example data under elasticsearch 8
context: the page
/documentation/datadictionary/dataset/{dataset}/field/{field}for dataset=processed currently throws a 500 error for text fields with no full version and no fielddatathis only changes the mapping to include multi-fields where there was none before, which is a valid mapping update, so it can theoretically be applied in-place in stage so we don't need a backfill