Fixes bug 725304 - Allowed infinite number of results instead of max …

…100.
mozilla-services · Feb 21, 2012 · 6b29887 · 6b29887
1 parent d808067
commit 6b29887
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 8 deletions.
diff --git a/docs/middleware.rst b/docs/middleware.rst
@@ -114,10 +114,6 @@ Optional parameters
 +------------------------+-------------------------------+----------------+---------------------------------------------------------------------------------------------------------------------------------------------------------+
 | plugin\_terms          | String or list of strings     | None           | Terms to search for. Several terms can be specified, separated by a + symbol. report\_process has to be set to plugin.                                  |
 +------------------------+-------------------------------+----------------+---------------------------------------------------------------------------------------------------------------------------------------------------------+
-| result\_number         | Integer                       | 100            | Number of results to return.                                                                                                                            |
-+------------------------+-------------------------------+----------------+---------------------------------------------------------------------------------------------------------------------------------------------------------+
-| result\_offset         | Integer                       | 0              | Offset of the first result to return.                                                                                                                   |
-+------------------------+-------------------------------+----------------+---------------------------------------------------------------------------------------------------------------------------------------------------------+
 
 Return value
 ^^^^^^^^^^^^

diff --git a/socorro/external/postgresql/crashes.py b/socorro/external/postgresql/crashes.py
@@ -108,13 +108,10 @@ def get_comments(self, **kwargs):
 
         sql_order = "ORDER BY email ASC, r.date_processed ASC"
 
-        (sql_limit, sql_params) = self.build_reports_sql_limit(params,
-                                                               sql_params)
-
         # Assembling the query
         sql_query = " ".join((
                 "/* external.postgresql.crashes.Crashes.get_comments */",
-                sql_select, sql_from, sql_where, sql_order, sql_limit))
+                sql_select, sql_from, sql_where, sql_order))
 
         # Query for counting the results
         sql_count_query = " ".join((