Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates entitylist to include key for license #235

Merged

Conversation

patjack
Copy link
Contributor

@patjack patjack commented Jun 30, 2020

Also moves entities to key entities. See: #223

say-yawn added a commit that referenced this pull request Jul 14, 2020
As entity structure updated in #235
@say-yawn
Copy link
Contributor

Depends on #250 and mozilla-services/shavar-list-creation#155

@say-yawn say-yawn requested a review from englehardt July 15, 2020 00:08
Copy link
Contributor

@say-yawn say-yawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM to me. Tested locally with the changes from list-creation and checked that it works. I'll be testing this on Staging before this goes live on the versioned branches.

@say-yawn say-yawn merged commit caac445 into mozilla-services:master Jul 16, 2020
say-yawn added a commit that referenced this pull request Jul 16, 2020
As entity structure updated in #235
say-yawn added a commit that referenced this pull request Jul 17, 2020
As entity structure updated in #235
say-yawn added a commit that referenced this pull request Jul 17, 2020
As entity structure updated in #235
say-yawn added a commit that referenced this pull request Jul 17, 2020
As entity structure updated in #235
say-yawn added a commit that referenced this pull request Jul 17, 2020
As entity structure updated in #235
say-yawn added a commit that referenced this pull request Jul 17, 2020
As entity structure updated in #235
say-yawn added a commit that referenced this pull request Jul 17, 2020
As entity structure updated in #235
say-yawn added a commit that referenced this pull request Jul 17, 2020
As entity structure updated in #235
say-yawn added a commit that referenced this pull request Jul 17, 2020
As entity structure updated in #235
say-yawn added a commit that referenced this pull request Jul 17, 2020
As entity structure updated in #235
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants