Update license in .JSON files from Disconnect

[say-yawn]

About this Issue

After #211 we have decided to move to Attribution-NonCommercial-ShareAlike 4.0 International. We should update the license key value pair in .JSON files from Disconnect

Acceptance Criteria

• Update license value in disconnect-blocklist.json
• Add license key value in disconnect-entitylist.json
• Follow-up issue created on shavar-prod-lists to document structure change and script change Document repo changes #249
• Follow-up issue created on trackingprotection-tools repo to update entity processing Update entity list parsing mozilla/trackingprotection-tools#18

[say-yawn]

Hey @patjack! While reviewing Shavar services I realized we did not update the license in the disconnect-blocklist.json and there was never a license key-value pair on the disconnect-entitylist.json. Can you please guide us/add a PR to update the licenses of these files?

P.S. I checked the Disconnect repo for the entities.json to see if you all had license on that but you all also did not have license key-value pair for entities.

cc @englehardt

[patjack]

Hi @say-yawn,

Thanks for the ping on this! Yes, we should add the license to this file. I'm thinking we can follow the same form as the blacklist and have entities moved to an entities key. Like this:

{

"license": "Copyright 2010-2020..."
"entities" : { }
}

If that sounds good to you I can submit a PR w/these changes. Thanks!

[say-yawn]

Yes that sounds great! Thanks for following-up. It seems I'll have to make some changes to how we handle entities on the list creation script, would it be possible to create two separate PRs for adding the licenses in blocklist and entitylist respectively?

[patjack]

No problem! Those two PRs will be arriving shortly.

[say-yawn]

All the changes to licenses are now reflected on main and versioned branches.