refactored code using assert #127
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
say-yawn
suggested changes
Apr 2, 2020
There was a problem hiding this comment.
Hi, thanks for contributing to Shavar services. I left some review and would like to add additional acceptance criteria for asserting that the file size does not exceed the max size. Since version 73 newer, the max size of files switched to 4 mebibytes (Mb). As a result, for versions lower than 73 we should check to make sure that the list size does not exceed 1Mb. I will add this comment on the issue as well.
|
Hi @skim1102 ! I have made the changes as required. Do let me know if any further changes are required! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solved #104
@skim1102 I have tried to refactor the error handling using the assert block. Kindly do let me know if any further changes are required!