External memory-usage tracking #195
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
washort
force-pushed
the
external-memory-tracking
branch
from
5ce51ba to
7e951f6
Compare
trink
suggested changes
May 9, 2017
| @@ -54,6 +54,8 @@ typedef struct lsb_heka_sandbox lsb_heka_sandbox; | |||
| typedef struct lsb_heka_stats { | |||
| unsigned long long mem_cur; | |||
| unsigned long long mem_max; | |||
| unsigned long long ext_mem_cur; | |||
There was a problem hiding this comment.
These need to be added to the end of the struct otherwise it will break existing clients.
| size_t newsize = hsb->lsb->usage[LSB_UT_EXTERNAL_MEMORY][LSB_US_CURRENT] + sizechange; | ||
|
|
||
| if (newsize > hsb->lsb->usage[LSB_UT_EXTERNAL_MEMORY][LSB_US_MAXIMUM]) { | ||
| hsb->lsb->usage[LSB_UT_EXTERNAL_MEMORY][LSB_US_MAXIMUM] = newsize; |
There was a problem hiding this comment.
This should report back an OOM condition
| }; | ||
| } | ||
|
|
||
| size_t lsb_heka_get_ext_memory_limit(lsb_heka_sandbox *hsb) |
There was a problem hiding this comment.
I don't believe this is needed as the adjustment should manage and report back an OOM condition. Also they could retrieve it through the stats function so it is a bit redundant.
|
|
||
| void lsb_heka_adjust_ext_memory_usage(lsb_heka_sandbox *hsb, int sizechange) | ||
| { | ||
| size_t newsize = hsb->lsb->usage[LSB_UT_EXTERNAL_MEMORY][LSB_US_CURRENT] + sizechange; |
There was a problem hiding this comment.
This should be pushed down to a lsb_adjust API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.