Skip to content

Commit

Permalink
Fix failing deployment workflow due to google auth action config (#110)
Browse files Browse the repository at this point in the history
* Add token permissions to build_parser_images job

* Use correct value for `workload_identity_provider` option

We now store this value as a workflow variable rather than a secret
  • Loading branch information
grahamalama authored Sep 16, 2024
1 parent 9fb792f commit b943759
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions .github/workflows/build-and-push-images.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@ jobs:
strategy:
matrix:
context: [argocd, circleci, github, pagerduty]
permissions:
contents: read
id-token: write
steps:
- uses: actions/checkout@v4
- uses: docker/setup-buildx-action@v3
Expand All @@ -27,7 +30,7 @@ jobs:
with:
token_format: 'access_token'
service_account: artifact-writer@${{ env.GCP_PROJECT_ID }}.iam.gserviceaccount.com
workload_identity_provider: ${{ secrets.WORKLOAD_IDENTITY_POOL_PROJECT_NUMBER }}
workload_identity_provider: ${{ vars.GCPV2_GITHUB_WORKLOAD_IDENTITY_PROVIDER }}

- uses: docker/login-action@v3
name: Docker login
Expand Down Expand Up @@ -62,7 +65,7 @@ jobs:
with:
token_format: 'access_token'
service_account: artifact-writer@${{ env.GCP_PROJECT_ID }}.iam.gserviceaccount.com
workload_identity_provider: ${{ secrets.WORKLOAD_IDENTITY_POOL_PROJECT_NUMBER }}
workload_identity_provider: ${{ vars.GCPV2_GITHUB_WORKLOAD_IDENTITY_PROVIDER }}

- uses: docker/login-action@v3
name: Docker login
Expand Down

0 comments on commit b943759

Please sign in to comment.