Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FXIOS-11322 #24638 [WebEngine] Native error page handling #24645

Merged
merged 11 commits into from
Feb 7, 2025

Conversation

lmarceau
Copy link
Contributor

@lmarceau lmarceau commented Feb 7, 2025

📜 Tickets

Jira ticket
Github issue

💡 Description

First pass at integrating native error pages inside the WebEngine. This is bascially using the same pattern as in production, but removing the html handling part of it since we want to only support native error pages in the WebEngine. The native error page is shown in the browser. We might need to pass in more information at a later point since not all native error pages are created at the moment. But this simplifies the code paths a bit.

Also needed to fix the SampleBrowser project with latest changes in sub-packages (namely the state were renamed to configuration).

📝 Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed, I updated documentation / comments for complex code and public methods
  • If needed, added a backport comment (example @Mergifyio backport release/v120)

@lmarceau lmarceau requested a review from a team as a code owner February 7, 2025 19:13
Copy link
Collaborator

@mattreaganmozilla mattreaganmozilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing major jumped out, lgtm 👍

@lmarceau lmarceau merged commit 054c4ef into main Feb 7, 2025
13 checks passed
@lmarceau lmarceau deleted the lm/FXIOS-11322-#24638-webengine-error-pages branch February 7, 2025 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants