Bugfix FXIOS-11307 [Homepage] [TopSites] top site layout on rotation #24634
+19
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Tickets
Jira ticket
Github issue
💡 Description
Fix how we determine the number of tiles for top sites. This issue only exists with the
Toolbar Redesign
disabled. This is because we are dispatching more actions with theToolbar Redesign
so it causes thenumberOfTilesPerRow
to re-calculate more often. The issue without the toolbar redesign is that we call the calculation less often and the last call was calculated with the wrong size.This change guarantees that we are calculating the proper number of tiles before the view changes and adding another dispatch causes the datasource to be updated.
📝 Checklist
You have to check all boxes before merging
@Mergifyio backport release/v120
)Screenshots
Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-02-07.at.10.25.30.mp4