Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPP-3652 - Update monitor branding #168

Merged
merged 2 commits into from
Jan 30, 2024
Merged

MPP-3652 - Update monitor branding #168

merged 2 commits into from
Jan 30, 2024

Conversation

lloan
Copy link
Contributor

@lloan lloan commented Jan 30, 2024

Update monitor branding

@lloan lloan requested a review from a team as a code owner January 30, 2024 17:20
@lloan lloan requested review from groovecoder and removed request for groovecoder January 30, 2024 17:20
Copy link
Contributor

@peiying2 peiying2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but the string ID must be updated.

en/layout.ftl Outdated
@@ -78,7 +78,7 @@ made-by-mozilla = Made by { -brand-name-mozilla }
fx-desktop = { -brand-name-firefox-browser } for Desktop
fx-lockwise = { -brand-name-firefox-lockwise }
fx-mobile = { -brand-name-firefox-browser } for Mobile
fx-monitor = { -brand-name-firefox-monitor }
fx-monitor = { -brand-name-mozilla-monitor }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's change the string ID too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed to moz-monitor

@peiying2 peiying2 merged commit a12c1b1 into main Jan 30, 2024
2 checks passed
@peiying2 peiying2 deleted the MPP-3652 branch January 30, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants