Minor fixes for local development #552
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bheesham
force-pushed
the
drop-dashes-from-env-names
branch
from
cf7268b to
9a3f0d3
Compare
|
I'll need to update the env file for local development stashed away in 1Pass after merging. |
|
@bheesham Just for historical context the "SSO-DASHBOARD" was a namespace prefix used by the Everett Config library. The first underscore in the env name string was the separator. This change would have broken that... BUT, since Everett has been removed many commits ago, you could go further and remove the entire prefix for all ENVs. Your call. |
Ou, yeah, I like that idea. I'll do the thing! |
The environment names were dictated by some library we no longer use. I removed that dependency, but kept the environment variables the same to not break stuff anything. This commit changes that to be shell-friendly. Before, if you wanted to write a script to run the app, you'd need to resort to using either an external app, or `env -S $(< envfile) flask ...`. By swapping to dashes we're a little more generic in the kinds of ways you can call the app. Jira: IAM-950
Generally just sorta nice to be able to talk to Redis by default.
This allows you to run the app using:
flask -A dashboard.app run -p 8000
(Assuming you have your environment set up for local dev, see previous commit.)
Jira: IAM-950
bheesham
force-pushed
the
drop-dashes-from-env-names
branch
from
9a3f0d3 to
b84aa60
Compare
|
@dividehex Done! I cleaned up some bits around |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I finally got annoyed enough to change things, removing requirements for tooling (wrappers around running flask or some local env manager).
Jira: IAM-950