Add support for nested bold hostname in popup string #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lesleyjanenorton
force-pushed
the
bold-hostname-in-string
branch
from
25918b9
to
6200e18
Compare
strseb
reviewed
Sep 23, 2024
| const el = document.createElement("p"); | ||
|
|
||
| // Replace "dummyString" with <span>origin</span> | ||
| const parts = localizedString.split(originPlaceholder); |
There was a problem hiding this comment.
This will create a new node on every render()
Using a lit template result will simply cause lit to update the text of the span :)
Maybe consider:
const parts = localizedString.split(originPlaceholder);
return html`
<p>
${parts.at(0)}
<span class="bold">${origin}</span>
${parts.at(-1)}
</p>
`
strseb
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for nested bold hostname in popup string.