Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FXVPN-337 Return of the loading screen #180

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

strseb
Copy link
Collaborator

@strseb strseb commented Jan 8, 2025

If you look closely on the Screen Recording Shared with QA, you see the Red dot on the Icon not appearing for quite a while.
This indicates firefox takes it's time inizializing the background script.

You can easily replicate that by dropping await new Promise((r) => setTimeout(r, Math.round(Math.random() * 5000))); somewhere in main::init().

Currently if we open the message port before the background script is done inizializing we are screaming into the void.
Sooo, let's allow ipc.js to close and re-open ports if there is noone answering on the other side.

For that ofc we need to show "Something" so i'm bringing back the loading screen we added and then removed. 🙈

Here is a demo with a random delay.

output


render() {
return html`
<vpn-titlebar title="Loading"> </vpn-titlebar>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note This is a hardcoded string. This is not a view people should see, so i chose that.
Otherwise should we use "Mozilla VPN" ? or just empty?

@@ -27,3 +27,13 @@ body {
.needsSlotted > * {
display: none;
}

.stack {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm using a grid to stack things, so the size is inherited from the child elements, (in contrast to pos-absolute stacking).

Also if we don't stack, we might show a blip with both at the same time on top of each other which is more noticable then when we stack them,.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant