workers: don't fail on ssh_private_key missing or empty in env (bug 1944728) #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit makes ssh_private_key a proper attribute of the base Worker, so we can simplify the emptiness checks without having to rely on the presence of the attribute itself.
shtrom
requested review from
zzzeid and
cgsheeh
and removed request for
zzzeid
cgsheeh
approved these changes
Jan 30, 2025
zzzeid
approved these changes
Jan 30, 2025
zzzeid
changed the title
We could, though at least in suite, we still use the SSH key to authenticate to git.test. It's a corner case, but using SSH for git is legitimate, so I think this is probably OK like this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.