main: update models and migration files (bug 1869032) #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
zzzeid
commented
Dec 13, 2023
•
zzzeid
commented
- translate remaining models to Django models
- generate new migration file
- port various methods and properties to use new models
- store patch as string rather than bytes
zzzeid
force-pushed
the
zeid/bug-1869032-port-models-and-migrations
branch
from
2cb0457 to
e2877f1
Compare
zzzeid
force-pushed
the
zeid/bug-1869849-consolidate-project-files
branch
3 times, most recently
from
b1ceb1b to
04b88de
Compare
Base automatically changed from
zeid/bug-1869849-consolidate-project-files
to
main
January 18, 2024 14:21
zzzeid
force-pushed
the
zeid/bug-1869032-port-models-and-migrations
branch
6 times, most recently
from
b4b7c6c to
33afa34
Compare
- translate remaining models to Django models - generate new migration file - port various methods and properties to use new models
zzzeid
force-pushed
the
zeid/bug-1869032-port-models-and-migrations
branch
from
33afa34 to
ea7594f
Compare
|
Bit of feature creep, but I know that we've previously discussed changing the way we store patches, and this is quite a simple change that I thought we could include here. |
cgsheeh
requested changes
Jan 30, 2024
Yes, I was going to make a comment about that but I came to the same conclusion as you. With the I know this is probably on your mind as well but the sooner we can get the existing LandoAPI tests running in this prototype the more confidence we will have about making such changes. :) |
cgsheeh
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.