Merge lando-ui repo #14
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the CircleCI build tag and push the 'latest' image tag to Docker Hub so that we can use the latest image in the demo.
Move the application logging configuration out of pages.py and into app.py. Use the new app logger to log some interesting application startup information.
Turn the Sentry client instance into a module-level object so that it is usable by other code.
The asset pipeline breaks during unit testing because it writes files to disk. We can break the test environment dependency by adding a flag to control the asset management machinery and turn that flag off during test runs.
The test environment breaks when running unit tests outside of the docker environment. Monkeypatch some key environment variables to break the environment dependencies.
Handle various lando-api http status codes and map them to sensible lando-ui http responses.
Turn on the TESTING setting so that exceptions within the app bubble up to the test runner. Otherwise Flask will hide the exception behind a generic HTTP 500 response, and that makes writing and debugging tests much harder.
Change the Lando API URL into a application setting so that we can access it from multiple places without scattering os.environ() calls everywhere.
The dockerflow health and version endpoints should instruct the caller not to cache any results. This commit sets Cache-Control to properly disable caching. Closes #51
Reviewers: imadueme Reviewed By: imadueme Bug #: 1402189 Differential Revision: https://phabricator.services.mozilla.com/D75
Summary: These notes include a reference to general Conduit contribution guidelines along with specifics of modifying the local hosts file and specifying a specific lando-api instance. Reviewers: imadueme Bug #: 1402189 Differential Revision: https://phabricator.services.mozilla.com/D76
Test Plan: Hover over the top logo, no background color change. Reviewers: imadueme Reviewed By: imadueme Differential Revision: https://phabricator.services.mozilla.com/D79
Reviewers: davidwalsh Reviewed By: davidwalsh Differential Revision: https://phabricator.services.mozilla.com/D154
Sentry is categorizing any unexpected response as a `JSONDecodeError` because those responses are typically returning HTML webpages or empty response bodies. Move the JSON decoding to it's own try/except block and attempt to raise the `requests` error in it's place.
Add license headers to all relevant files in-tree. This is essentially everything (all Python, SASS, JS etc) except the vendored copy of Bulma.
…ug 1814207) (#157) `old/` has been unused for some time. `how_to_localdev.md` is horribly out of date, and Suite should be used instead. `README.md` has a bunch of linting errors caught by markdownlint, so fix them as well. Co-authored-by: Zeid Zabaneh <[email protected]>
… (Bug 1759890) (#159) Since we divide a value in half in `graph_x_pos`, we can technically return a `float. Force the value into an `int` with `//` division.
Bumps [sentry-sdk](https://github.com/getsentry/sentry-python) from 1.11.1 to 1.14.0. - [Release notes](https://github.com/getsentry/sentry-python/releases) - [Changelog](https://github.com/getsentry/sentry-python/blob/master/CHANGELOG.md) - [Commits](getsentry/sentry-python@1.11.1...1.14.0) --- updated-dependencies: - dependency-name: sentry-sdk dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…request button (Bug 1818383) (#167)
#170) Mount the full Lando-UI source directory into `/app` in the container to conform with how Lando-API mounts volumes. Add `FLASK_DEBUG=1` to the environment to enable hot-reloading.
…m (Bug 1861534) (#183) Clarify the wording of the patch conflicts error message so it is more obvious where the issue is arising from. Also add a hint that rebasing your patches on the latest revision from the landing repo may fix the problem.
Add type hints to functions in `app.py`. The `use_https` kwarg is used as a `bool` but is passed as an `int` 0 in some places. Update usages to Python `bool`, which is more correct.
Add a `from_environment` class method to avoid repeated code for building a Lando-API object.
zzzeid
force-pushed
the
zeid-bug-1867357-lando-ui
branch
from
6657b7e to
6433f74
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.