Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1919849 - Some features on modal new bug page are not working as expected #2328

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

kyoshino
Copy link
Collaborator

@kyoshino kyoshino commented Sep 19, 2024

Bug 1919849 - Some features on modal new bug page are not working as expected

jQuery in bug_modal.js has some $('#comment', '#changeform'), meaning the <form> has to have id="changeform" to match the comment <textarea>.

The modal bug details page has id="changeform" for sure, but somehow the modal new bug page has id="create-form", which breaks the following features. This PR makes the ID consistent so that the shared script will work.

  • Add Description button
  • Comment draft auto saving in local storage
  • Comment <textarea> auto resize
  • Make comment private checkbox that makes the comment text red

@dklawren dklawren merged commit 0f2c3b5 into mozilla-bteam:master Sep 19, 2024
17 checks passed
@kyoshino kyoshino deleted the bug-1919849-new-bug-fallout branch September 19, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants