Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1917167 - Disable emoji reactions for users without editbugs on bugs that have commenting restricted #2317

Merged
merged 7 commits into from
Sep 9, 2024

Conversation

kyoshino
Copy link
Collaborator

@kyoshino kyoshino commented Sep 7, 2024

Bug 1917167 - Disable emoji reactions for users without editbugs on bugs that have commenting restricted

Restrict emoji reactions as with bug comments. The reaction button will be hidden from non-editbugs users, and the API usage will also fail.

template/en/default/global/user-error.html.tmpl Outdated Show resolved Hide resolved
Copy link
Collaborator

@globau globau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text next to the restrict comments checkbox on show_bug should be updated to indicate this also restricts reactions (ie "Restrict commenting and reactions on this …")

The Impact section of extensions/RestrictComments/template/en/default/pages/restrict_comments_guidelines.html.tmpl also needs updating

@kyoshino kyoshino requested a review from globau September 9, 2024 05:17
@dklawren dklawren merged commit 61f9707 into mozilla-bteam:master Sep 9, 2024
1 check passed
@kyoshino kyoshino deleted the 1917167-restrict-reactions branch September 9, 2024 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants