Bug 1904151 - Updates and improvements to Bugzilla/Report/Graph.pm and Bugzilla/API/V1/BugGraph.pm #2265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
dklawren
commented
Jun 21, 2024
•
dklawren
commented
- Use breadth first instread of depth first for generating the JSON tree for /rest/bug/123/graph
- https://metacpan.org/pod/Graph::Traversal::BFS
- Move the code that filters secure bugs and resolved bug to Bugzilla/Report/Graph.pm
- This will allow later for showdependencytree.cgi and showdependencygraph.cgi to switch over to using Bugzilla/Report/Graph instead of each generating the trees themselves. This will remove duplication.
- Will file separate bugs for the work in above
…d Bugzilla/API/V1/BugGraph.pm
cgsheeh
approved these changes
Jun 21, 2024
I mistakenly was using depth-first which meant the tree was being returned in the wrong order. breadth-first starts from the root bug and id and the order is more correct and matches the showdependencytree.cgi output. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.