Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added eslint-plugin-css-modules support #74

Closed
wants to merge 18 commits into from

Conversation

adao99
Copy link

@adao99 adao99 commented Oct 31, 2019

fixes #45

.gitignore Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
addons/css.js Outdated Show resolved Hide resolved
test/fixtures/rules/css/.eslintrc.json Outdated Show resolved Hide resolved
test/fixtures/rules/css/all-css-class-errors.js Outdated Show resolved Hide resolved
test/fixtures/samples/css/.eslintrc.json Outdated Show resolved Hide resolved
test/fixtures/rules/css/test.css Outdated Show resolved Hide resolved
test/fixtures/rules/css/test.css Outdated Show resolved Hide resolved
Made the necessary changes for the pull request
@codecov
Copy link

codecov bot commented Nov 1, 2019

Codecov Report

Merging #74 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #74   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          23     25    +2     
  Lines          27     29    +2     
=====================================
+ Hits           27     29    +2
Impacted Files Coverage Δ
rules/css-modules.js 100% <100%> (ø)
addons/css-modules.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cab6d84...09e566c. Read the comment docs.

forgot to remove css samples folder
.gitignore Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
test/fixtures/rules/css-modules/undefined.js Outdated Show resolved Hide resolved
test/fixtures/rules/css-modules/undefined.js Outdated Show resolved Hide resolved
test/fixtures/rules/css-modules/unused.js Outdated Show resolved Hide resolved
test/fixtures/rules/css-modules/unused.js Outdated Show resolved Hide resolved
test/fixtures/rules/css-modules/undefined.js Outdated Show resolved Hide resolved
test/fixtures/rules/css-modules/unused.js Outdated Show resolved Hide resolved
test/fixtures/rules/css-modules/undefined.js Outdated Show resolved Hide resolved
changes from second review of pull request
@satazor
Copy link
Contributor

satazor commented Nov 1, 2019

Almost there!

test/fixtures/rules/css-modules/unused.js Outdated Show resolved Hide resolved
test/fixtures/rules/css-modules/unused.js Outdated Show resolved Hide resolved
test/fixtures/rules/css-modules/unused.js Outdated Show resolved Hide resolved
test/fixtures/rules/css-modules/undefined.js Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
fixed css addon to css-modules
@satazor
Copy link
Contributor

satazor commented Nov 1, 2019

@adao99 this is ready to be merged.

However, I have a few concerns about eslint-plugin-css-modules as it has a lot of bugs and is not functioning correctly when using postcss, e.g.: with nesting, see: atfzl/eslint-plugin-css-modules#25. Moreover, the README says it's not maintained anymore.

We do have https://github.com/bmatcuk/eslint-plugin-postcss-modules which seems better in the sense that uses postcss, and has the exact same rules! I think you briefly mentioned this when we met at OPO.js, correct? Anyway, for the OSS challenge, there's no need for you to change the plugin to the postcss one, unless you want to.

@acostalima
Copy link
Contributor

@satazor should this be merged or closed? 🤔

@satazor
Copy link
Contributor

satazor commented Jan 8, 2020

This can indeed be closed!

@satazor satazor closed this Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider using eslint-plugin-postcss-modules
3 participants