Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the response text parsing and encoding issue when the moly and mofa agents communicate locally. #336

Closed
wants to merge 10 commits into from

Conversation

ZhangHanDong
Copy link
Contributor

The main fixes are for two issues:

  1. Fix the response text parsing and encoding issue when the moly and mofa agents communicate locally.
  2. If access to OpenAI or Claude is restricted in certain regions, a VPN is typically used, so communication with the local MoFA service here must bypass the proxy.

image

@joulei
Copy link
Collaborator

joulei commented Jan 2, 2025

Hi @ZhangHanDong thanks for the PR. The proxy bypass looks good.
Also the changes or parsing seem to work and look OK, but I'll wait before merging because this change is unexpected.
Until recently the response from MoFa servers (both locally and the remote servers) was formatted differently, and in any case we were expecting a cleanup of the response. I'll ask the MoFa team about this.

@joulei
Copy link
Collaborator

joulei commented Jan 21, 2025

Hi @ZhangHanDong, thanks for working this but fortunately we were able to clean up the response from the MoFa side so that all this parsing is not needed. I've merged an update here: #353
The proxy bypass is in another PR: #354
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants