Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove logrus in favour of log/slog #286

Merged
merged 5 commits into from
Nov 4, 2024
Merged

Remove logrus in favour of log/slog #286

merged 5 commits into from
Nov 4, 2024

Conversation

pkqk
Copy link
Member

@pkqk pkqk commented Oct 24, 2024

This lets us remove a dependency and use the standard library.

The API is a bit less direct than the logrus or even log packages but the message parts can be hidden in only a few places.

There is no formatting options of the log calls or a Fatal option so I've had to put explicit os.Exit(1) calls in the few locations.

I've also cleaned up some of the error messages to make them have consistent tenses and not use the word error in the error message.

@pkqk pkqk requested a review from a team as a code owner October 24, 2024 20:46
@pkqk pkqk force-pushed the slog branch 5 times, most recently from a318e1d to 1b1bc16 Compare October 24, 2024 22:42
@pkqk pkqk merged commit 3bf8465 into main Nov 4, 2024
6 checks passed
@pkqk pkqk deleted the slog branch November 4, 2024 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant