Framework Cleanup #108
Closed
Framework Cleanup #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eliminate the async dependency in consensus-types.
Stub out the status field in ProofWithData with the vector that's evenutally supposed to be retrieved, until we figure out if we need the field and the whole structure at all.
aptos-consensus had code that provided consensus-types data in asynchronous sends. Since we are not likely to need this crate anyway, cut it out of the workspace. Also remove any dependent crates.
It's only used in test code, move it to dev-dependencies
ENG-251 aptos-logger: cut out async logging
ENG-180: Cut out async dependencies from consensus-types and async-vm
…-block-reversion ENG-206 Implement Block Reversion
Some tests still had these.
AptosDB::commit_reversion_ledger_info does the same thing as commit_ledger_info, just use that method instead.
This wrapper is meant to represent the finalized state for the API.
No randomness allows us to verify the hash.
get_read_delegatee needs to deref to get the vtable for the pointee type.
FinalityView::set_finalized_block_height better describes the argument.
…le in complete_bridge_transfer
…rove), add nonzero nonce check
Co-authored-by: Primata <[email protected]>
Framework Move modules and spec for Trusted Relayer Native Bridge
…th side. Move unit tests pass, still working on E2E Move tests
…he expected bridge transfer ID
…for now to help reviewers make sense of everything
Native bridge: Modify param serialization to make bridge transfer IDs match on Move and Solidity sides in both L1 -> L2 and L2 -> L1 directions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Which Components or Systems Does This Change Impact?
How Has This Been Tested?
Move unit tests and
Key Areas to Review
Checklist