Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install Gazebo as part of Tutorials image build #937

Merged
merged 2 commits into from
Aug 2, 2024

Conversation

sea-bass
Copy link
Contributor

@sea-bass sea-bass commented Aug 1, 2024

Description

There have been issues building the tutorials image because now some of the packages (namely Robotiq and ros2_kortex) depend on Gazebo being installed.

This will work for Jazzy/Rolling, but I think there need to be args introduced to make this work on other distros (or even changing gz for ignition)

So you will then need to pass in this GZ_VERSION arg in the moveit2 CI job here: https://github.com/moveit/moveit2/blob/1d93035fc4fbc2831916bce26d7b03e15b8a86d5/.github/workflows/tutorial_docker.yaml#L19

NOTE: You should see the effects of this in the post-merge action for this PR. I've also dispatched the workflow so you can see it on this branch: https://github.com/moveit/moveit2_tutorials/actions/runs/10207096230

(all previous failing runs can be found here: https://github.com/moveit/moveit2_tutorials/actions/workflows/docker.yml)

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • While waiting for someone to review your request, please consider reviewing another open pull request to support the maintainers

@sea-bass sea-bass force-pushed the fix-tutorial-image-build branch from e6155bc to 756d5b5 Compare August 1, 2024 22:38
@sea-bass sea-bass requested review from henningkayser and sjahr August 1, 2024 22:42
@sea-bass
Copy link
Contributor Author

sea-bass commented Aug 1, 2024

An alternative to all this, btw, is to remove the dependency on ros_gz_sim from the ros2_kortex package... while that wouldn't be "proper", as it factually depends on Gazebo, you could consider it an optional dependency given it's just an option in some of the xacros.

@sea-bass sea-bass requested a review from stephanie-eng August 2, 2024 11:54
Copy link
Contributor

@sjahr sjahr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this. I think for now this is a good way forward

@sjahr sjahr merged commit b1a23f3 into main Aug 2, 2024
10 checks passed
@sjahr sjahr deleted the fix-tutorial-image-build branch August 2, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants