Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RobotState::getRigidlyConnectedParentLinkModel and subframes: PRs not ported from moveit1. #3279

Open
rr-mark opened this issue Jan 27, 2025 · 0 comments · May be fixed by #3284
Open

RobotState::getRigidlyConnectedParentLinkModel and subframes: PRs not ported from moveit1. #3279

rr-mark opened this issue Jan 27, 2025 · 0 comments · May be fixed by #3284
Labels
bug Something isn't working

Comments

@rr-mark
Copy link

rr-mark commented Jan 27, 2025 •
edited
Loading

RobotState::getRigidlyConnectedParentLinkModel fails when the frame is a subframe.

In moveit1, this is fixed by a6f8bb9 331381a 593a119 and 4a3a312.

It is not straightforward to patch these across, as Moveit2 has 1f23344 and f20265a.

Should 1f23344 and f20265a be reverted, and the four PRs from Moveit1 be patched across? Or are 1f23344 and f20265a still relevant after those four PRs? And if so, should they be backported to Moveit1?
@rr-mark rr-mark added the bug Something isn't working label Jan 27, 2025
@rr-mark rr-mark changed the title RobotState::getRigidlyConnectedParentLinkModel: PRs missing from moveit1. RobotState::getRigidlyConnectedParentLinkModel and subframes: PRs not ported from moveit1. Jan 27, 2025
This was referenced Jan 28, 2025
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
1 participant
@rr-mark