Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade graphql and typescript dependencies #1

Merged
merged 5 commits into from
Nov 14, 2023

Conversation

jacopoRufini
Copy link
Collaborator

This PR was born to upgrade graphql-ws and apollo-client dependencies and became a fight with the dependency hell of javascript. What we did:

  • updated the version of the library by a minor, we want the next version to be 0.9.0.
  • updated the desired dependencies to latest: graphql-ws and apollo-client
  • updated the undesired dependencies:
    • typescript, since apollo client was using internally some new features of the language
    • eslint, since it was outdated for the new typescript version
    • jest

Some dependencies had breaking changes so we managed to fix them in the most easy way.

  • All the imports from '@apollo/client' were refactored in '@apollo/client/core, since the core part does not include React, and we were having problems importing react (that actually we don't need).
  • src/subscription.ts now uses shouldRetry instead of isFatalConnectionProblem as a configuration to enable retries on fatal errors, since the latter is deprecated
  • We fixed the type of V in the methods subscribe, createQuery, createMutation since the underlying library added some constraints on it

@jacopoRufini jacopoRufini self-assigned this Nov 13, 2023
@psenderos psenderos merged commit db73c9a into main Nov 14, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants