feat(GameScreen): add "follow my bot" button #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
November 27, 2024 14:45
added zoom out and zoom in feature for when following bot.
yurijmikhalevich
changed the title
|
Resolved the conflicts and changed the follow button label. |
|
Fixed the error that I was getting on first load. |
|
@aldrin312, thank you for the update 🙌 I'll take another look later this week. |
|
Fixed the issue. Demo: |
…ngs#92) ## How does this PR impact the user? https://github.com/user-attachments/assets/89f97e3f-75d4-414b-b102-0c86fd24eda8 ## Description - Added `/api/state` to public paths to make current game publicly accessible. - Updated the login screen to display the login form on the left and the current game on the right (reused the code from `index.vue`). - Moved the login form to a separate component (`/components/LoginForm.vue`). - Increased the timeout for the login e2e tests to 60 seconds, as 30 seconds timeout was insufficient for the tests to complete. ## Limitations The game screen takes a couple of seconds to load. ## Checklist - [x] my PR is focused and contains one wholistic change - [x] I have added screenshots or screen recordings to show the changes
|
I'll try looking into the |
yurijmikhalevich
approved these changes
Dec 21, 2024
yurijmikhalevich
merged commit 68ee712
into
move-fast-and-break-things:main
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How does this PR impact the user?
Description
Limitations
Checklist