Skip to content

Support "QtSvgWidgets.QSvgWidget" #411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

ababak
Copy link

@ababak ababak commented May 24, 2024

No description provided.

@CLAassistant
Copy link

CLAassistant commented May 24, 2024

CLA assistant check
All committers have signed the CLA.

@MHendricks
Copy link
Collaborator

Thanks for the pull request. Sorry for the delay, I'm working my way through the backlog now that I'm starting to maintain Qt.py.

It looks like you moved the binding to QtSvgWidgets which is correct for PySide6 but for the current Qt4, Qt5 and Qt6 support design of Qt.py it probably should be put on QtSvg instead.

Members of Qt.py is a subset of PySide2. Which means for a member to be made accessible via Qt.py, it will need to (1) be accessible via PySide2 and (2) each of the other supported bindings.

However once we drop Qt4 support we may change the reference from PySide2 to PySide6, which would mean the correct location is back to QtSvgWidgets. #413 (comment)

I think for now we should add it back to QtSvg, but depending on the responses to #413 (comment) it would eventually be added to the new QtSvgWidgets.

Also, it looks like we lost another svg member QGraphicsSvgItem. It was also moved into QtSvgWidgets and should probably be restored.

@MHendricks MHendricks self-assigned this Apr 16, 2025
@MHendricks
Copy link
Collaborator

I'm going to close this pull request and address the issue with #434 once #431 is merged.

@MHendricks MHendricks closed this Apr 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants