Add cista::raw::string overload of parse_value #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbruechert
force-pushed
the
csv-quote-alloc
branch
from
d7196b9
to
c5e330b
Compare
This one only allocates if necessary.
jbruechert
force-pushed
the
csv-quote-alloc
branch
from
c5e330b
to
df3e349
Compare
felixguendling
requested changes
May 3, 2024
include/utl/parser/csv.h
Outdated
| cista::raw::string out; | ||
|
|
||
| if (arg.contains(R"("")")) { | ||
| std::string mut_string = arg.to_str(); |
There was a problem hiding this comment.
I added a cista::generic_string::erase function:
felixguendling/cista#218
With this, I hope it's possible to eliminate this temporary allocation.
There was a problem hiding this comment.
That seems useful, but I can't get pkg to not reset my changes as soon as I edit .pkg to update cista.
There was a problem hiding this comment.
pkg will for each dependency
- checkout the latest commit found in any
.pkgfile, if the commit ref does not match - if the commit ref matches, nothing will change (so you can do changes)
So the moment you create a commit in a dependency, you need to change the referenced version in the .pkg file to this latest commit, otherwise the previous version will be checked out.
|
Maybe it's better to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one only allocates if necessary.