-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python packaging #134
base: master
Are you sure you want to change the base?
Python packaging #134
Conversation
Pelican 5.x $ sed -i 's/import\ pelican.signals/from\ pelican\ import\ signals/g' plugins/m/* $ sed -i 's/pelican\.signals\./signals\./g' plugins/m/*
Codecov Report
@@ Coverage Diff @@
## master #134 +/- ##
=======================================
Coverage 98.28% 98.28%
=======================================
Files 27 28 +1
Lines 6646 6647 +1
Branches 44 44
=======================================
+ Hits 6532 6533 +1
Misses 114 114
Continue to review full report at Codecov.
|
You probably want to add the Classifiers |
This PR does not have |
@sizmailov That can be difficult. Entry points are added to packages, and with this PR every file under "plugins" is regarded as a package. This is important for the next pelican release which supports import-able plugins. While documentation can be added to the package source distribution, setting it as an entry point is not possible ... unless the documentation is an installable python package - which it is not. |
IMO You are right that turning (Also note that CI did not pass, rebase on master should help) |
Packages all plugins (*.py), css and html data has to be explicitly added if it would be published on PyPI.
Fixes #82.
Previous attempt #97.