-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: modernize dependencies #112
base: master
Are you sure you want to change the base?
Conversation
Btw: we might want to replace Kind regards, |
I think I already did this on aedes or mqttjs, do you prefer to go for it here or another PR? |
Lets do this in a next PR. Its not an urgent issue for now. Kind regards, |
.github/workflows/ci.yml
Outdated
@@ -11,17 +11,17 @@ jobs: | |||
runs-on: ubuntu-latest | |||
strategy: | |||
matrix: | |||
node-version: [14.x, 16.x, 18.x] | |||
node-version: ['lts/-1', 'lts/*', 'node'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please no. Keep the version picked as we don't want to roll them automatically.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please elaborate a bit more on why you want to fix versions? I would like to get a better understanding as I use the rolling versions in my own projects as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Btw: I just pinned the NodeJS versions in CI
This PR closes: #111, it:
docker compose
instead ofdocker-compose
which is not supported onUbuntu:latest
action runners anymorestandard
&snappy
byeslint
&neostandard
tape
&faucet
bynode:test
Enjoy!
Kind regards,
Hans