fix: wills table de duplicate

[friesendrywall]

This proposal is a companion fix to aedes to allow sending wills on startup. Also, this addresses issue #102 with duplicate WILLKEY items.

[robertsLando]

Could you add a test that covers this?

[friesendrywall]

My implementation was wrong for streaming wills, so I removed it, and only added the de-duplication tests. I think this needs to be managed in aedes mostly, although its possible the persistence layer may need to be tweaked to allow a broker to pull only its own wills.

[friesendrywall]

Changed to streamWill

[friesendrywall]

lrem is the only decent way to test for item counts matching the key. I don't think the API exposes that in any other way at present.

…

On Mon, Jul 25, 2022, 3:13 AM Daniel Lando ***@***.***> wrote: ***@***.**** requested changes on this pull request. ------------------------------ In test.js <#104 (comment)> : > + + const packet = { + cmd: 'publish', + topic: 'hello', + payload: 'willsTest', + qos: 1, + retain: false, + brokerId: instance.broker.id, + brokerCounter: 42, + messageId: 123 + } + + instance.putWill(client, packet, err => { + instance.putWill(client, packet, err => { + const key = `will:${instance.broker.id}:${encodeURIComponent(client.id)}` + instance._db.lrem('will', 0, key, function (err, value) { why are you manually calling lrem here on db? shouldn't that be done in putWill ? — Reply to this email directly, view it on GitHub <#104 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABKBETQ5RAL5KNLASHP3GJ3VVY5CXANCNFSM53YPQTIA> . You are receiving this because you authored the thread.Message ID: ***@***.***>