Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: modernize dependencies #36

Merged
merged 7 commits into from
Feb 24, 2025

Conversation

seriousme
Copy link
Contributor

@seriousme seriousme commented Feb 21, 2025

This PR modernizes dependencies:

  • CI now uses recent versions of both NodeJS and the Github actions used during CI.
  • qlobber, aedes and aedes-persistence have been updated to their latest versions
  • concat-stream , mqemitter and through2 were not used

Mind you: pre-commit still gives 2 "High" warnings on npm audit and the module seems to be abandoned. So you might want to remove this as well.

Kind regards,
Hans

Copy link
Member

@robertsLando robertsLando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@robertsLando
Copy link
Member

@seriousme please fix conflicts :)

@mcollina
Copy link
Collaborator

switch to @fastify/pre-commit

@seriousme
Copy link
Contributor Author

Resolved conflicts and replaced pre-commit by @fastify/pre-commit
Looks all green now :-)
Btw: npm install still gives out warnings because of tape and standard

npm warn deprecated [email protected]: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.
npm warn deprecated @humanwhocodes/[email protected]: Use @eslint/config-array instead
npm warn deprecated [email protected]: Rimraf versions prior to v4 are no longer supported
npm warn deprecated [email protected]: Glob versions prior to v9 are no longer supported
npm warn deprecated @humanwhocodes/[email protected]: Use @eslint/object-schema instead
npm warn deprecated [email protected]: This version is no longer supported. Please see https://eslint.org/version-support for other options.

even though they are at their latest versions.
We might want to switch to tap or node:test, but then we need to fix aedes-persistence testing first because of the dependency in between aedes-persistence and aedes-persistence-level during testing.
standard seems to be replaced by plain eslint or @biomejs/biome in other projects.

Happy to help out if you are interested.

Kind regards,
Hans

@robertsLando
Copy link
Member

@seriousme I'm absolutely +1 for the switch to node:test and eslint everywhere 👍🏼

@robertsLando robertsLando merged commit 540248f into moscajs:master Feb 24, 2025
3 checks passed
@seriousme seriousme deleted the modernize-dependencies branch February 24, 2025 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants