Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FAQs to indicate wrapping not supported #822

Merged
merged 4 commits into from
Nov 4, 2024

Conversation

milocress
Copy link
Contributor

Description of changes:

Updates the FAQs to reflect #789 , where users mentioned a lack of documentation on whether wrapping the streaming dataset will cause runs to fail.

Issue #, if available:

Merge Checklist:

Put an x without space in the boxes that apply. If you are unsure about any checklist, please don't hesitate to ask. We are here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the contributor guidelines
  • This is a documentation change or typo fix. If so, skip the rest of this checklist.
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the MosaicML team.
  • I have updated any necessary documentation, including README and API docs (if appropriate).

Tests

  • I ran pre-commit on my change. (check out the pre-commit section of prerequisites)
  • I have added tests that prove my fix is effective or that my feature works (if appropriate).
  • I ran the tests locally to make sure it pass. (check out testing)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes.

Copy link
Collaborator

@snarayan21 snarayan21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just edited comments to be more clear, can you accept then merge?

docs/source/getting_started/faqs_and_tips.md Outdated Show resolved Hide resolved
docs/source/getting_started/faqs_and_tips.md Outdated Show resolved Hide resolved
@snarayan21 snarayan21 enabled auto-merge (squash) November 4, 2024 18:54
@milocress milocress enabled auto-merge (squash) November 4, 2024 19:02
@milocress milocress merged commit a3edf7d into main Nov 4, 2024
7 checks passed
@milocress milocress deleted the milo/update-faq-for-wrapping branch November 4, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants