-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Catch bad data prep #1644
Catch bad data prep #1644
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder why fetch
is writing empty rows. Do we why this fails silently? @milocress
I believe there is a situation where |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some minor comments. Thanks Milo!
When privatelink blocks a delta table from being downloaded, this fails silently in the dataset preparation script.
This PR adds a validation step to check that the downloaded file indeed exists and contains data to prevent this kind of silent error.