Put extra arg test back #1641
Open
Put extra arg test back #1641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dakinggg
reviewed
Nov 5, 2024
| mock_stat = MagicMock() | ||
| mock_stat.st_size = 1024 # Mock st_size with a desired value | ||
| mock_stat.st_mode = 33188 # Regular file mode for Unix-based systems | ||
| def custom_stat_mock(path: Any): |
There was a problem hiding this comment.
this is some really intense patching, are you sure this test can't be made simpler?
There was a problem hiding this comment.
Hmm, should be, but I was not able to come up with one. Any suggestions? I basically need
os.path.exists(filelocks) to behave normally, and other os.stat to return a mock stat when testing with private-streaming.
XiaohanZhangCMU
force-pushed
the
xiaohan/enable_extra_arg_test
branch
from
c7d8e89
to
4922cd1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With streaming upgraded to 0.9.1, the unit test would lead to inf loop.