New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up yamls #58

Merged

Landanjs merged 2 commits into mosaicml:main from Landanjs:landan/cleanup_yamls

Aug 21, 2023

Contributor

Landanjs commented Aug 14, 2023

Remove diffusion2
Add the parameter paths to the composer command
Remove scale schedule ratio since we don't do that anymore
Remove 'batch_sizein the train and eval dataset config sincetrain.pydividestrain_batch_sizeandeval_batch_size` by the number of devices. To me, removing this improves clarity
Change multi-step LR schedule to linear LR schedule with alpha_f=0
Refactor compute to the more modern form, I think?


          Clean up yamls

56e31b6

Landanjs requested a review from coryMosaicML

August 14, 2023 20:54


          Fix trailing whitespace

2cfb7ba

coryMosaicML approved these changes

View reviewed changes

Collaborator

coryMosaicML left a comment

LGTM! Thank you for doing this cleanup.

yamls/hydra-yamls/SD-2-base-256.yaml Show resolved Hide resolved

yamls/hydra-yamls/SD-2-base-256.yaml Show resolved Hide resolved

Landanjs merged commit ee8d0b2 into mosaicml:main

7 checks passed

Landanjs deleted the landan/cleanup_yamls branch

August 21, 2023 20:52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet