Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unwrap mlflow 401/403 errors #3688

Closed
wants to merge 1 commit into from
+8 −1
Closed

Unwrap mlflow 401/403 errors #3688

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion composer/utils/object_store/mlflow_object_store.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,9 +61,16 @@ def _wrap_mlflow_exceptions(uri: str, e: Exception):
]
retryable_client_codes = [ErrorCode.Name(code) for code in [ABORTED, REQUEST_LIMIT_EXCEEDED, RESOURCE_EXHAUSTED]]
not_found_codes = [ErrorCode.Name(code) for code in [RESOURCE_DOES_NOT_EXIST, NOT_FOUND, ENDPOINT_NOT_FOUND]]

# MLflow wraps Azure data exceptions as INTERNAL_ERROR. Need to unwrap and check msg for the specific error.
non_retryable_internal_error_codes = [
'401',
'403',
]
if isinstance(e, MlflowException):
error_code = e.error_code # pyright: ignore
if error_code == ErrorCode.Name(INTERNAL_ERROR):
if any(e.message.startswith(code) for code in non_retryable_internal_error_codes):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do these error messages always start with 401??

Copy link
Contributor Author

@mattyding mattyding Oct 29, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think there are any example of 401 private link errors. I was just including it because there was a comment at some point about wrapping both 401 and 403 errors

raise e
if error_code in retryable_server_codes or error_code in retryable_client_codes:
raise ObjectStoreTransientError(error_code) from e
elif error_code in not_found_codes:
Expand Down
Loading