Fix/some rework on remote service & remote resource #1182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- turn remote service start into steps, thus delay remote driver construction on remote host - fix certain remote cmd gen utils - explicitly disallow remote resource usage on windows hosts - fix empty report check in certain exporters - add cleanup for dangling symlink due to workspace imitation on remote host, rearrange some source in remote resource as well - fix a bug in driver dep graph type check
zhenyu-ms
force-pushed
the
re-remote-service
branch
from
a123cde to
944cb0c
Compare
Pyifan
requested changes
Feb 17, 2025
| self._copy_testplan_package() | ||
|
|
||
| exist_on_remote = self._check_workspace() | ||
| self._prepare_workspace(exist_on_remote) |
There was a problem hiding this comment.
for user's case, testplan package (when it is a venv) is most likely under workspace
Pyifan
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug / Requirement Description
TODO
Solution description
Checklist: