Introducing Scopes #102
Closed
Introducing Scopes #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Roaders
previously approved these changes
Oct 31, 2024
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
aidanm3341
commented
Dec 6, 2024
| type Channels = (keyof typeof this.channelLookup)[]; | ||
| (Object.keys(this.channelLookup) as Channels).forEach((channelName) => this.dispose(channelName)); | ||
|
|
||
| if (this._parent) { |
There was a problem hiding this comment.
do we need to remove ourselves from the parents children array?
There was a problem hiding this comment.
I've currently got it set up so that there is no children's array anymore. Since messages only propagate up, I didn't have a use for storing children
|
I'm going to close this PR for now and reraise it later with some rewrites |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added the concept of Scopes to the MessageBroker. This is a mechanism for building a tree of message brokers in which messages will propagate up the tree until either the root is reacher, or a broker is found which has a subscriber to handle the message.
One outstanding question on this implementation is if the semantics for disposing of a scope is complete. Currently you can
.destroy()a broker, which will unlink it from its parent meaning messages will no longer propagate up. Should this functionality do anything else? E.g. should it unlink itself from any children scopes as well?